Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Q3 Pro DIP switch custom behavior #282

Conversation

IonAgorria
Copy link

Description

Currently is not possible to disable or override original Win/Mac DIP behavior in custom keymaps code, these changes allow that so that DIP switch can be used in different ways.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

By adding KEYCHRON_DIP_SWITCH_USER definiton in rules.mk
the Win/Mac DIP behavior can be disabled.
Also return the dip_switch_update_user() call value
@lokher lokher deleted the branch Keychron:wireless_playground August 17, 2024 09:10
@lokher lokher closed this Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants